-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linter doesn't work #16
Comments
@sunabozu Compared to Atom's eslint interface packages, this repo is relative stable. I don't think here is the right place for your issue. And if you really want us to help you, please provide more information about your environment, like:
|
As I mentioned above, eslint still works with plain js files, the problem occurs only with vue components. So I thought it has something to do with this package. I have the latest versions of the mentioned packages: Atom 1.4.1, linter-eslint 6.0.0, base linter 1.11.3. Plus babel-eslint@4.1.6 (via npm). I'm not quite sure what you mean by the interface package. |
This issue is most likely caused by following lines in linter-eslint/main.js : const embeddedScope = 'source.js.embedded.html'
this.subscriptions.add(atom.config.observe('linter-eslint.lintHtmlFiles', lintHtmlFiles => {
if (lintHtmlFiles) {
this.scopes.push(embeddedScope)
} else {
if (this.scopes.indexOf(embeddedScope) !== -1) {
this.scopes.splice(this.scopes.indexOf(embeddedScope), 1)
}
}
})) The solution is to enable "Linter HTML Files" in the settings of I had never used |
Your solution works for me too. Thanks! I guess, the problem is solved now. |
Since eslint-plugin-vue has now moved away from https://github.com/BenoitZugmeyer/eslint-plugin-html, I wonder what the best/right way is, to get linting feedback for |
Guess |
This topic merits reopening as this solution doesn't work with the |
Hi. I'm having this problem. The previous solution did not work for me |
Indeed, this solution no longer works. |
hi! is any solution like this for Sublime Text 3? :'( |
Following these instructions got Atom linting .vue files for me: |
Hi.
Today I noticed eslint stopped working in tabs with opened
.vue
files. I'm pretty sure it worked before, and it still works for regular.js
files. Perhaps it has something to do with 1.4.1 update, although I'm not sure what packages this problem related to.The text was updated successfully, but these errors were encountered: