Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Picker lablel's character is displaced when using combination of single and double byte characters #40

Open
sasurau4 opened this issue Aug 3, 2018 · 2 comments
Assignees
Labels

Comments

@sasurau4
Copy link
Contributor

sasurau4 commented Aug 3, 2018

Summery

When using combination single and double byte character sentence as Picker dialog label, double byte characters are shifted up a little compared to single byte character in iOS.
On Android work fine and perfect!

Reporoduce example

Exmample snack is here

In snack, this year is 2017 is correctly displayed.
The other hand 今年は2018年です and 올해는 2016 년입니다 are displaced.
Double-byte characters 今年は are shifted up a little compared to single-byte characters 2018.

Is there a solution to fix it?

P.S.
react-native-material-dialog is awesome and very useful! Thanks! 👍

@hectahertz
Copy link
Owner

Hi @sasurau4,

This is caused by a bug in the lineHeight property, see example snack here. It only happens after Expo SDK v25.0.0 (React Native 0.54).

There is an issue on the react-native repo for this (facebook/react-native#19193) but I'll also leave this issue open so we can keep track of it.

Thanks for taking your time explaining the issue so well and for your words 🙂

@sasurau4
Copy link
Contributor Author

sasurau4 commented Aug 5, 2018

@hectahertz
Thanks for your reply!
I got it! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants