Skip valid_class check if no class defined

[TALlama]

#1656

Previously, we would check for validity all the time, even if the outcome of the check added no class. This meant that there was no way to opt out of the check in cases where it was expensive (if the file is stored in S3, in our example).

Now, we only check for validity if there is a valid_class defined to be added if the field is valid.

[TALlama]

Anything I can do to expedite review? This issue is currently blocking us from updating simple_form, which is blocking us from updating to Rails 5.2.

[feliperenan]

This test is not covering your changes - I put back the deleted code and it still pass. One way I can think right now in how to test it, would be with something like:

  test 'wrapper does not determine if valid class is needed when it is set to nil' do
    @user.instance_eval { undef errors }
    with_form_for @user, :name, wrapper: custom_wrapper_with_input_valid_class(valid_class: nil)

    assert_no_select 'div.field_without_errors'
  end

A better test would checking if input.valid? has not been called at all, but I don't know how to do it 🙈

[feliperenan]

Hi @TALlama

Thanks for your contribution and sorry about the delay 🙌 . Before we decide whether or not to move forward with this, I'd like to know if you are still facing this issue or did you work around it somehow?