-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug or by designed ? Sidebars don't stick on main page, but on "detailed" page only? #131
Comments
It's expected, the sidebar will be sticky until reaching the footer, same as detail pages. |
![]() as shown, on page https://theme-cards.hbstack.dev/ it doesn't work. working now, but but reaching the footer. Not reaching the footer. (maybe I misunderstood what you meant) |
Cloud you please provide full screenshot, OS and browser (version)? |
Following the discussion #265 can you reopen this issue? Thanks! |
The problem here is that the sidebar widgets aren't scrolling down until reaching the footer, which makes the sidebar partly hidden, even when there's space to show it fully. However, the sidebar seems to be working as it should on the demonstration site. No empty space at the bottom of the sidebar. |
The main reason I don't think it's worth is that, the user doesn't focus on (care about) the sidebar when they already reached the footer. There are some popular sites do the same. For example,
That's because there has enough content to take full height of sidebar, there will be always empty space if you don't have enough content.
I didn't get the ugly, if you mean the gap between of the ad and sidebar, then it should be a duty of the ad block, you can assign a Decision Although I don't think it would be useful, I'll provide a module to achieve that, since Flexible and Customizable is one of this framework's features and goals. Please note that, it may not happen too fast. |
When the visitor reached the footer, I prefer to give him options to either leave by clicking an affiliate banner or stay by reading another article. That's why a visible sidebar with its widgets is a most. Do you think that adding this npm package to the theme's dependencies is useful? Or this for individual widgets? |
@LITUATUI I've implemented a simple solution for this, but naming is difficult, I'd name the module as Will release the module in those two days. |
Thanks @razonyang. That name works for me, it's clear in what it does. |
Preview: sticky-till-the-end.mp4To achieve this, you'd need to import I'm closing this now, please open another issue if there is a bug. |
Please put those modules under |
For example, Sidebars doesn't stick well on https://theme-cards.hbstack.dev (it kind of works)
but on stick well on https://theme-cards.hbstack.dev/blog/2023/11/diagrams-and-charts/
it should keep the same consistence.
The text was updated successfully, but these errors were encountered: