Some view functions will revert when the system is paused

[hats-bug-reporter]

Github username: --
Twitter username: --
HATS Profile: ---

Beneficiary: 0x3828b7Dff72E340B44f3A0270574dDE9276D5FD3
Submission hash (on-chain): 0x783ca866be3dcff95ec8c06381655bf932675ee614a8ddacfe3416723bdcd251
Severity: low

Description:
In recent changes, pause functionality was added to pause governance and locking functions.

The issue is this functionality can lead to the revert of some view functions:

• Locking::totalSupply()
• Locking::balanceOf()
• LockingVotes::getVotes()
• LockingVotes::getPastVotes()
• LockingVotes::getPastTotalSupply()

This issue can lead to the broke of third-party contracts that rely on these view functions to perform, and it's not the intended behavior.

Recommendation

To fix this issue, consider implementing the whenNotPaused modifier:

modifier whenNotPaused(){
      require(!paused, "locking is paused");
      _;
    }

Then, add this modifier to the functions that need to revert when the protocol is paused.

[nvtaveras]

As mentioned in the scope of the audit, the revert of all the above functions is intentional in order to pause related Locking and Governance functions during the L2 transition period.