Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Happy refactoring (happy-1.21): either move forward or take it back #255

Closed
andreasabel opened this issue Sep 30, 2023 · 6 comments · Fixed by #256
Closed

Happy refactoring (happy-1.21): either move forward or take it back #255

andreasabel opened this issue Sep 30, 2023 · 6 comments · Fixed by #256
Milestone

Comments

@andreasabel
Copy link
Member

ATTN: @Ericson2314 @int-index

happy-1.21 included large refactorings, was released in October 2021 but then unreleased shortly after. It is soon that this is two years ago.

Unfortunately, in the current state, with refactorings applied but a boot-strapping problem persisting, master is not releasable. This also means that fixing issues is stalled, as the fate of those fixes would be unknown.

I only see two options now:

  1. Either finish to work done in 2021 to bring it to a releasable state.
  2. Or take this work back and bring master back into a releasable state based on the happy-1.20 code.

Since I am mostly interested in the stability of happy, I don't care much which path is taken. However, I think that something has to happen soon.

@andreasabel andreasabel added this to the 1.21 milestone Sep 30, 2023
@int-index
Copy link
Collaborator

I've lost all context by now. What would it take to make happy releasable without reverting the refactorings?

@andreasabel
Copy link
Member Author

I think the context can be recovered by starting here:

@int-index
Copy link
Collaborator

OK. This really is an issue with Cabal, but we can work around it. We need a custom script to generate release tarballs with Bootstrapped.hs pre-generated from Bootstrapped.ly. I'll try to do it and see how well it works.

@andreasabel
Copy link
Member Author

Note that currently (1.20) one has to make sdist to make a custom tarball as well. (Plain cabal sdist does not generate a boot-strappable tarball.) Maybe something similiar can be put in place for 1.21.

@int-index int-index mentioned this issue Oct 1, 2023
@Ericson2314
Copy link
Collaborator

Yeah you are right @andreasabel, this has dragged on long enough.

@int-index
Copy link
Collaborator

See #238 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants