Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is this repo up to date? #1012

Closed
erikd opened this issue Jul 14, 2024 · 7 comments
Closed

Is this repo up to date? #1012

erikd opened this issue Jul 14, 2024 · 7 comments

Comments

@erikd
Copy link
Member

erikd commented Jul 14, 2024

The latest version latest version in this repo is 0.6.8, but the latest on Hackage is 0.7.

Can this repo please be updated? Both the code changes and the tags need to be updated.

@erikd
Copy link
Member Author

erikd commented Jul 14, 2024

Have mailed the libraries mailing list: https://mail.haskell.org/pipermail/libraries/2024-July/031664.html

@treeowl
Copy link
Contributor

treeowl commented Jul 14, 2024

There was a slight git screwup and the version bump needs to be merged from a branch, with changelog conflicts and such resolved. Do you have time to take a look at doing that? If not, I'll try to do it in the next two days.

@erikd
Copy link
Member Author

erikd commented Jul 14, 2024

Thanks @treeowl . If you give me some hints, I can take a look, but I can also wait a couple of days.

@meooow25
Copy link
Contributor

There seems to be two issues here.

  1. A tag for the 0.7 version, already exists: https://github.com/haskell/containers/releases/tag/v0.7. @erikd does this work for you?
  2. Updating the cabal file on master to 0.7 because it still says 0.6.8. @treeowl had a PR for this (Merge 0.7 #994). I can take a shot at updating it.

@erikd
Copy link
Member Author

erikd commented Jul 29, 2024

Sorry, I needed to do git pull --tags to get the required tag 🤦

@erikd
Copy link
Member Author

erikd commented Jul 29, 2024

The tag does not build with ghc-9.10.1 and requires:

diff --git a/containers-tests/containers-tests.cabal b/containers-tests/containers-tests.cabal
index 5d3ea2b8..b58374e5 100644
--- a/containers-tests/containers-tests.cabal
+++ b/containers-tests/containers-tests.cabal
@@ -37,7 +37,7 @@ common deps
   build-depends:
       array    >=0.4.0.0
     , base     >=4.10    && <5
-    , deepseq  >=1.2     && <1.5
+    , deepseq  >=1.2     && <1.6
     , template-haskell
 
 common test-deps
@@ -54,7 +54,7 @@ common benchmark-deps
   import: deps
   build-depends:
       containers-tests
-    , deepseq           >=1.1.0.0 && <1.5
+    , deepseq           >=1.1.0.0 && <1.6
     , tasty-bench       >=0.3.1   && <0.4
 
 -- Copy of containers library,

This only affects the containers-tests package so does not affect the package on Hackage.

@erikd
Copy link
Member Author

erikd commented Jul 29, 2024

Closing this as resolved.

@erikd erikd closed this as completed Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants