Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing the "count conflicts" solver feature, since it may be redundant with "fine grained conflicts" #8931

Open
grayjay opened this issue May 2, 2023 · 0 comments

Comments

@grayjay
Copy link
Collaborator

grayjay commented May 2, 2023

The "count conflicts" feature significantly improved solver performance when it was implemented, but the "fine grained conflicts" feature was added later and may provide the same benefits. This issue is for running the benchmarks in https://github.com/haskell/cabal/tree/master/solver-benchmarks to compare enabling and disabling --count-conflicts while --fine-grained-conflicts is enabled. If the average run time is similar, and there are no cases that are handled much better by --count-conflicts, then I think we can remove the feature in order to simplify the code.

PRs that added the two features:

#3513 --count-conflicts
#5918 --fine-grained-conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant