-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Cabal flag to embed assets with TH #66
Comments
I will leave it up to @23Skidoo to decide as he's the primary maintainer nowadays. |
I think that TH is fine if it's hidden behind a flag, but if you do this please also add a CI configuration that tests the TH build variant. |
@23Skidoo Nice, we'll of course add a CI configuration to build TH version too! |
@fizruk do you still plan to work on the PR ? |
@fizruk Have you guys arrived at anything in the end with this? |
@nikita-volkov @Unisay we have been using our fork which is linked in this discussion and can be found at GetShopTV#1. We've been using it with Stack as follows: - git: https://github.com/GetShopTV/ekg.git
commit: f94af6a0fdd12e73a824c965c57053d7ce3e7ca1 We did not make the CI configuration for it at the time so we failed to report back here, sorry about that! Currently we are not using |
✨ This is an old work account. Please reference @brandonchinn178 for all future communication ✨ Bump. Would be great to get more discussion on this |
See #77 (comment) |
@tibbe I see in #22 (comment) that you don't want TH in this package:
However, we're pretty fine with TH in dependencies and we've been using
servant-swagger-ui
that embeds its assets just fine.So would you mind if we add a Cabal flag (disabled by default) that would enable TH-based embedding?
The text was updated successfully, but these errors were encountered: