Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve comment detection #935

Merged
merged 1 commit into from
Feb 11, 2022
Merged

Improve comment detection #935

merged 1 commit into from
Feb 11, 2022

Conversation

jpogran
Copy link
Contributor

@jpogran jpogran commented Feb 11, 2022

This disambiguates hash line comments, double slash comments, and block comments by adding unique identifiers. This will allow different highlighting for different comment types, as well as help with future code folding and keyboard shortcuts.

This disambiguates hash line comments, double slash comments, and block comments by adding unique identifiers. This will allow different highlighting for different comment types, as well as help with future code folding and keyboard shortcuts.
@jpogran jpogran self-assigned this Feb 11, 2022
@jpogran jpogran added syntax enhancement New feature or request labels Feb 11, 2022
@jpogran jpogran requested a review from a team February 11, 2022 01:19
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

Copy link
Member

@dbanck dbanck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea!

@jpogran jpogran merged commit 54b3be8 into main Feb 11, 2022
@jpogran jpogran deleted the improve_comments branch February 11, 2022 13:02
@jpogran jpogran added this to the 2.20.0 milestone Feb 18, 2022
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request syntax
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants