Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Node 16 and VS Code 1.61 #904

Merged
merged 7 commits into from
Jan 13, 2022
Merged

Update to Node 16 and VS Code 1.61 #904

merged 7 commits into from
Jan 13, 2022

Conversation

jpogran
Copy link
Contributor

@jpogran jpogran commented Jan 13, 2022

This commit updates the project to move to VS Code 1.61. It moves nodejs to 16.X, typescript to 4.5 and vsce to 2.6.

A small fix to SingleInstanceTimeout is needed until we remove this class when we use platform specific extensions.

@jpogran jpogran force-pushed the update_vscode_1.61 branch from 51fb6fe to 012bdac Compare January 13, 2022 15:51
This commit updates the project to move to VS Code 1.61. It moves nodejs to 16.X, typescript to 4.5 and vsce to 2.6.

A small fix to SingleInstanceTimeout is needed until we remove this class when we use platform specific extensions.
@jpogran jpogran force-pushed the update_vscode_1.61 branch from 012bdac to ea52831 Compare January 13, 2022 15:55
@jpogran jpogran requested a review from a team January 13, 2022 16:01
@jpogran jpogran self-assigned this Jan 13, 2022
@jpogran jpogran added ci Continuous integration/delivery related dependencies Auto-pinning enhancement New feature or request labels Jan 13, 2022
@jpogran jpogran marked this pull request as ready for review January 13, 2022 16:02
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any particular reason for the differences between VS Code versions here?

  • GitHub Action CI environment (1.61.2)
  • package.json engines requirement (^1.61.0) - shouldn't that be ~1.61.X instead?
  • @types/vscode (^1.61.0)

Aside from that (and my minor suggestion in-line) LGTM!

Co-authored-by: Radek Simko <radek.simko@gmail.com>
@jpogran
Copy link
Contributor Author

jpogran commented Jan 13, 2022

The engines.vscode version indicates the lowest version of VS Code the extension will be offered for. So, anyone who is at or above 1.61.0 will 'see' our extension offered to them either in the Marketplace or via code --install-extension. While this respects npm version constraint system, the point is more for a line in the sand rather than something to reference in CI.

The version specified in test.yml is so we can download specific versions straight from code.visualstudio.com. VS Code has released 1.61.0, 1.61.1, and 1.61.2 for the 1.61 series. I selected the 1.61.2 as the latest version for the 1.61 series to test on. If I had selected 1.61.0, 1.61.0 would be downloaded and we wouldn't be testing on the latest 1.61 series.

The @types/vscode set to 1.61.0 was a mistake of mine. It should be set to 1.61.1, which is latest types available for that series. We could specifcy 1.61.X if you want.

@radeksimko
Copy link
Member

Gotcha - that explanation makes sense - thank you! 👍🏻 Happy with 1.61.1 types.

Copy link
Member

@dbanck dbanck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Just a few suggestions and a way to fix the setTimeout type error.

@jpogran jpogran requested review from dbanck and radeksimko January 13, 2022 18:18
Copy link
Member

@dbanck dbanck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@jpogran jpogran merged commit 0dd533a into main Jan 13, 2022
@jpogran jpogran deleted the update_vscode_1.61 branch January 13, 2022 18:25
@dbanck dbanck mentioned this pull request Jan 19, 2022
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ci Continuous integration/delivery related dependencies Auto-pinning enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants