-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Node 16 and VS Code 1.61 #904
Conversation
51fb6fe
to
012bdac
Compare
This commit updates the project to move to VS Code 1.61. It moves nodejs to 16.X, typescript to 4.5 and vsce to 2.6. A small fix to SingleInstanceTimeout is needed until we remove this class when we use platform specific extensions.
012bdac
to
ea52831
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any particular reason for the differences between VS Code versions here?
- GitHub Action CI environment (
1.61.2
) - package.json
engines
requirement (^1.61.0
) - shouldn't that be~1.61.X
instead? @types/vscode
(^1.61.0
)
Aside from that (and my minor suggestion in-line) LGTM!
Co-authored-by: Radek Simko <radek.simko@gmail.com>
The The version specified in test.yml is so we can download specific versions straight from code.visualstudio.com. VS Code has released 1.61.0, 1.61.1, and 1.61.2 for the 1.61 series. I selected the 1.61.2 as the latest version for the 1.61 series to test on. If I had selected 1.61.0, 1.61.0 would be downloaded and we wouldn't be testing on the latest 1.61 series. The |
Gotcha - that explanation makes sense - thank you! 👍🏻 Happy with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Just a few suggestions and a way to fix the setTimeout type error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
This commit updates the project to move to VS Code 1.61. It moves nodejs to 16.X, typescript to 4.5 and vsce to 2.6.
A small fix to SingleInstanceTimeout is needed until we remove this class when we use platform specific extensions.