Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test VS Code Version Matrix #886

Merged
merged 4 commits into from
Jan 10, 2022
Merged

Test VS Code Version Matrix #886

merged 4 commits into from
Jan 10, 2022

Conversation

jpogran
Copy link
Contributor

@jpogran jpogran commented Jan 4, 2022

Change default npm test behavior to use the version of VS Code specified in the VSCODE_VER environment variable, instead of testing hardcoded versions inside runtest.ts.

VSCODE_VER supports latest, insiders and version numbers lik 1.55.0.

If the VSCODE_VER environment variable is not specified, then the latest stable version of VS Code is automatically used.

@jpogran jpogran force-pushed the add_vscode_ver_test_matrix branch 2 times, most recently from d7c7066 to e598301 Compare January 4, 2022 20:47
@jpogran jpogran requested a review from a team January 4, 2022 21:01
@jpogran jpogran self-assigned this Jan 4, 2022
@jpogran jpogran added the enhancement New feature or request label Jan 4, 2022
@jpogran
Copy link
Contributor Author

jpogran commented Jan 4, 2022

Good news, we now have separate runs for each platform and each vs code version we currently test against.

Bad news, have uncovered an actual problem with vs code 1.55.0

@jpogran
Copy link
Contributor Author

jpogran commented Jan 4, 2022

1.58.2 works

@jpogran jpogran force-pushed the add_vscode_ver_test_matrix branch from e598301 to a0c6d94 Compare January 6, 2022 16:17
jpogran added 2 commits January 6, 2022 11:17
@jpogran
Test VS Code Version Matrix
2c4d545 
Change default `npm test` behavior to use the version of VS Code specified in the `VSCODE_VERSION` environment variable, instead of testing hardcoded versions inside `runtest.ts`.

`VSCODE_VER` supports stable, insiders and version numbers like 1.55.0.

If the `VSCODE_VER` environment variable is not specified, then the latest stable version of VS Code is automatically used.
@jpogran
Pin to 1.58.2
843e906
@jpogran jpogran force-pushed the add_vscode_ver_test_matrix branch from a0c6d94 to 843e906 Compare January 6, 2022 16:20
@jpogran
Copy link
Contributor Author

jpogran commented Jan 6, 2022

VS Code 1.55 was released in March 2021. 1.58 was release in June 2021. A small subset of our users are still on 1.55 or lower.

The test that is erroring is an autocompletion expectation. The rest of the extension tests out ok.

As a result of all of the above, I pinned to 1.58.2 as there are no user reports from 1.55 users.

@jpogran jpogran marked this pull request as ready for review January 6, 2022 16:27
dbanck
dbanck approved these changes Jan 7, 2022
View reviewed changes
Copy link
Member

@dbanck dbanck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just added a suggestion to get rid of some code, but I'm also fine if you want to keep it.

dbanck
dbanck approved these changes Jan 7, 2022
View reviewed changes
Copy link
Member

@dbanck dbanck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@jpogran jpogran merged commit 30c55b8 into main Jan 10, 2022
@jpogran jpogran deleted the add_vscode_ver_test_matrix branch January 10, 2022 13:30
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dbanck dbanck dbanck approved these changes

Assignees

@jpogran jpogran

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpogran @dbanck