-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add end to end extension to language server testing #1739
Conversation
83017e9
to
33b5092
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really good work ❤️ ! I think these integration tests will help us a lot in the future!
I added some suggestions on how to reduce the potential flakiness and how to bring back the mocha helpers.
Co-authored-by: Daniel Banck <dbanck@users.noreply.github.com>
… start to test that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Organizes and adds the following tests:
Migrate to vscode-cli
Removes the original test runner infrastructure and replaces it with vscode-cli, which is the new recommend testing approach. This helps simplify executing VS Code API tests and helps ensure terraform-ls is up and initialized before running tests.
Notes
We now have two test folders:
src/test
andtest/specs
, along with two fixtures folders:test/fixtures
andtestFixtures
. This does not address combining them or moving them because the wdio tsconfig/npm packaging conflicts with the vscode ones.