Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix testing on VS Code Insiders #1644

Merged
merged 2 commits into from
Nov 29, 2023
Merged

Fix testing on VS Code Insiders #1644

merged 2 commits into from
Nov 29, 2023

Conversation

jpogran
Copy link
Contributor

@jpogran jpogran commented Nov 29, 2023

This updates to the latest @vscode/test-electron version which includes fixes for downloading vscode apps. It also adds dummy text to the code action file so that there are code actions returned.

@jpogran jpogran self-assigned this Nov 29, 2023
Ensuring we are on at least 2.3.8 brings in the fix for downloading vscode releases.
Code Actions seem to return null without text present in the test file.
@jpogran jpogran force-pushed the update-vscode-test-electron branch from e5327b5 to f6f0a84 Compare November 29, 2023 16:36
@jpogran jpogran changed the title Update vscode/test-electron Fix testing on VS Code Insiders Nov 29, 2023
@jpogran jpogran marked this pull request as ready for review November 29, 2023 16:48
@jpogran jpogran requested a review from a team as a code owner November 29, 2023 16:48
@jpogran jpogran merged commit 11d16bf into main Nov 29, 2023
@jpogran jpogran deleted the update-vscode-test-electron branch November 29, 2023 17:02
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants