Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove terraform.languageServer.trace.server #1048

Merged
merged 1 commit into from
Apr 13, 2022
Merged

Remove terraform.languageServer.trace.server #1048

merged 1 commit into from
Apr 13, 2022

Conversation

jpogran
Copy link
Contributor

@jpogran jpogran commented Apr 13, 2022

No description provided.

@jpogran jpogran requested a review from a team as a code owner April 13, 2022 12:27
@jpogran jpogran added this to the v2.22.0 milestone Apr 13, 2022
@jpogran jpogran added the documentation Improvements or additions to documentation label Apr 13, 2022
@jpogran jpogran self-assigned this Apr 13, 2022
radeksimko
radeksimko approved these changes Apr 13, 2022
View reviewed changes
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that this is already no-op (and AFAIK always has been - at least throughout v2 versions) I'd be also okay with just removing it, but I'm unsure of the UX implications for the end users who have this declared in their configs.

@jpogran
Copy link
Contributor Author

jpogran commented Apr 13, 2022 •
edited
Loading

Given that this is already no-op (and AFAIK always has been - at least throughout v2 versions) I'd be also okay with just removing it, but I'm unsure of the UX implications for the end users who have this declared in their configs.

Removing it entirely does not break anything, it will just be grayed out in the JSON file and won't show at all in the UI. If a user hovers over the setting in the JSON file, they'll be given a general message that the setting is no longer used.

I'd rather remove entirely than wait 2 release cycles for something that does nothing. 😁

@radeksimko
Copy link
Member

I'd rather remove entirely than wait 2 release cycles for something that does nothing.

👍🏻 Same, let's remove it then

@jpogran
Remove terraform.languageServer.trace.server
2b9daae 
This removes the terraform.languageServer.trace.server setting. This setting is not used by the extension or terraform-ls.

Removing it entirely does not break anything, it will just be grayed out in the JSON file and won't show at all in the UI. If a user hovers over the setting in the JSON file, they'll be given a general message that the setting is no longer used.
@jpogran jpogran force-pushed the deprecate-trace-server branch from 318ac50 to 2b9daae Compare April 13, 2022 13:12
@jpogran jpogran changed the title Deprecate terraform.languageServer.trace.server Remove terraform.languageServer.trace.server Apr 13, 2022
@jpogran jpogran requested a review from radeksimko April 13, 2022 13:16
@jpogran jpogran merged commit 3e06a3e into main Apr 13, 2022
@jpogran jpogran deleted the deprecate-trace-server branch April 13, 2022 13:46
@jpogran jpogran added the breaking Changes that require a Major version bump label Apr 19, 2022
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@radeksimko radeksimko radeksimko approved these changes

Assignees

@jpogran jpogran

Labels
breaking Changes that require a Major version bump documentation Improvements or additions to documentation
Projects
None yet
Milestone
v2.22.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jpogran @radeksimko