Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow disabling of terraform cloud #1631

Closed
1 task
mokshasoul opened this issue Nov 17, 2023 · 9 comments
Closed
1 task

Allow disabling of terraform cloud #1631

mokshasoul opened this issue Nov 17, 2023 · 9 comments

Comments

@mokshasoul
Copy link

Extension Version

v2.29.0

Problem Statement

Terraform cloud is currently not opt-in, and is always activated with the add in

Expected User Experience

I would like to see an option that disables terraform cloud completely

Proposal

No response

References

No response

Help Wanted

  • I'm interested in contributing a fix myself

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment
@mokshasoul mokshasoul added the enhancement New feature or request label Nov 17, 2023
@dbanck
Copy link
Member

dbanck commented Nov 17, 2023

Hi @mokshasoul,

The icon in the activity bar is the only place where the Terraform Cloud functionality shows up. If you don't want to use Terraform Cloud, you can right-click on the icon to hide the functionality and continue using the extension as usual.

CleanShot 2023-11-17 at 18 06 53@2x

Let me know if this solves the problem or if there is anything else you want to disable.

@dbanck dbanck added question waiting-response and removed enhancement New feature or request labels Nov 17, 2023
@mokshasoul
Copy link
Author

Hi @dbanck I also do not want it to show up when I'm doing CMD+SHIFT+P this is my main issue

@jpogran
Copy link
Contributor

jpogran commented Nov 21, 2023

Hey @mokshasoul, thanks for the additional detail about what the main issue is. Controlling the visibility of commands in the Command Palette is normally a straightforward process, but is complicated a bit with how VS Code handles view container visibility. I'll work to figure out a solution that ties their visibility to the icon being hidden.

@thequailman
Copy link

Why not move the Terraform Cloud stuff to a separate extension?

Copy link

github-actions bot commented Jan 7, 2024

Marking this issue as stale due to inactivity over the last 30 days. This helps our maintainers find and focus on the active issues. If this issue receives no comments in the next 30 days it will automatically be closed. Maintainers can also remove the stale label.

Thank you for understanding.

@github-actions github-actions bot added the stale label Jan 7, 2024
@mokshasoul
Copy link
Author

mokshasoul commented Jan 11, 2024

@jpogran so in essence its just that typing terraform something very fast Terraform Cloud comes on top:
image

But IMO if someone is not using terraform cloud then there's no reason for the commands to be there, its more an inconvenience rather than a bug

@github-actions github-actions bot removed the stale label Jan 11, 2024
@jpogran
Copy link
Contributor

jpogran commented Jan 12, 2024

Thanks @mokshasoul for the bump. This got a little delayed because of the holidays and catching up after that.

I recently merged #1643, which works to hide Terraform Cloud commands if the TFC view is not visible. The PR has a couple of screenshots to show what that looks like. It will be going out in the next release.

Unfortunately, due to the way views work inside VS Code, I'm not able to hide the automatically generated view commands as those are created when the extension activates by VS Code. I'm still working on what to do here, but hopefully this helps things in the interim.

@mokshasoul
Copy link
Author

oh wow that's great, yea no problem I totally forgot to reply. Thanks a lot for your work !!

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants