Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish new VS Codium release #1263

Closed
torhovland opened this issue Nov 1, 2022 · 5 comments
Closed

Publish new VS Codium release #1263

torhovland opened this issue Nov 1, 2022 · 5 comments
Labels
ci Continuous integration/delivery related enhancement New feature or request

Comments

@torhovland
Copy link

torhovland commented Nov 1, 2022

Server Version

❯ terraform-ls --version
zsh: command not found: terraform-ls

❯ /Users/tor/.vscode-oss/extensions/hashicorp.terraform-2.20.0-universal/bin/terraform-ls
zsh: exec format error: /Users/tor/.vscode-oss/extensions/hashicorp.terraform-2.20.0-universal/bin/terraform-ls

Terraform Version

❯ terraform -v
Terraform v1.3.2
on darwin_arm64

Your version of Terraform is out of date! The latest version
is 1.3.3. You can update by downloading from https://www.terraform.io/downloads.html

Client Version

VSCodium v1.72.2

Expected Behavior

No error message.

Actual Behavior

Error message.

Steps to Reproduce

  1. In VSCodium, install the HashiCorp Terraform extension.
  2. It should fail to start.
  3. Running terraform-ls outside VSCodium should also fail.
@radeksimko radeksimko transferred this issue from hashicorp/terraform-ls Nov 1, 2022
@radeksimko
Copy link
Member

Hi @torhovland
As you're running it in VS Codium, I'll refer you to #1064 which in turn is still currently blocked by EclipseFdn/open-vsx.org#1084

TL;DR We only published a relatively old release (2.20.0) of the extension to open-vsx, because open-vsx does not support platform-specific releases yet.

I am not sure why exactly does that version not work on M1 - I can try to reproduce on my M1, but if it is indeed broken, it's unlikely we'd be able to fix it at this point anyway, as we don't have any easy way to cut patch releases for such old versions.

The best we can do here is to have you install the LS binary separately and point to it, or wait for open-vsx maintainers to resolve the issue as described in EclipseFdn/open-vsx.org#1084

https://github.com/hashicorp/terraform-ls/blob/main/docs/installation.md#manual-installation
Once installed, you can then set "terraform.languageServer.path" to the appropriate path, likely just to "terraform-ls", if you launch VS Codium with the right $PATH.

@radeksimko radeksimko added enhancement New feature or request ci Continuous integration/delivery related labels Nov 1, 2022
@radeksimko radeksimko changed the title Cannot run on Apple M1 MacBook Pro Publish new VS Codium release Nov 1, 2022
@radeksimko
Copy link
Member

I forgot to mention, that earlier versions, including 2.20.0 had different setting structure/names. The differences are documented here: https://github.com/hashicorp/vscode-terraform/blob/main/docs/settings-migration.md

@torhovland
Copy link
Author

Thank you, that worked. I had to put this in my settings, though:

  "terraform.languageServer": {
    "external": true,
    "pathToBinary": "terraform-ls",
    "args": [ "serve" ],
    "ignoreSingleFileWarning": false
  }

@dbanck
Copy link
Member

dbanck commented Nov 21, 2022

I'm happy to report that the latest version 2.25.0 of the extension is now available on OpenVSX as well: https://open-vsx.org/extension/hashicorp/terraform. Future versions will be published automatically whenever we release an update.

The extension should work out of the box now and doesn't require additional settings. We also provide a way to auto-migrate your configuration to the latest version. You can remove the pathToBinary setting if you like since we now bundle the latest language server version with the extension.

I'm going to close this as resolved for now. However, please feel free to open another issue if you run into any problems upgrading.

@dbanck dbanck closed this as completed Nov 21, 2022
@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ci Continuous integration/delivery related enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants