Add Data Source for a Nomad ACL Policy. #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needed for the Test to work: * Instance of Nomad with ACL enabled * Run the `nomad acl bootstrap` command to get a secret_id * Set the NOMAD_TOKEN environment variable to the secret_id
lgfa29
suggested changes
Oct 22, 2019
There was a problem hiding this comment.
Thanks for the PR!
Setting the token to run the tests is fine, we have instructions in the README for this, so it's not a problem.
I've added a few change requests, feel free to comment on them if you have any question.
Could you also add a documentation page for this data source? The docs are located under the website folder.
|
Thank you for the feedback! I'm working on getting it all implemented now. |
|
I believe that I have everything addressed. Let me know if there's anything else. Thanks! |
|
I also just merged a PR that might conflict with your work, but it should be simple to fix it. Let me know if you need any help on that. |
|
@lgfa29 thanks! I have pushed those changes. |
lgfa29
approved these changes
Oct 30, 2019
|
Thank you for the updates 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #82.
Needed for the Test to work:
nomad acl bootstrapcommand to get a secret_idGiven that there are already tests for the
nomad_acl_policyresource that actually create and delete policies, I don't think that this should be a problem.