resource: new sso auth method binding rule resources #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgfa29
reviewed
Feb 1, 2023
Comment on lines
+220
to
+225
| _ = d.Set("name", authMethod.Name) | ||
| _ = d.Set("type", authMethod.Type) | ||
| _ = d.Set("token_locality", authMethod.TokenLocality) | ||
| _ = d.Set("max_token_ttl", authMethod.MaxTokenTTL) | ||
| _ = d.Set("default", authMethod.Default) | ||
| _ = d.Set("config", flattenACLAuthMethodConfig(authMethod.Config)) |
There was a problem hiding this comment.
There's a StateWriter helper to handle multiple Set like this, but we haven't use it much yet 😅
https://github.com/hashicorp/terraform-provider-nomad/blob/main/nomad/data_source_scaling_policy.go#L74-L79
bebf91e to
8a1dae5
Compare
lgfa29
approved these changes
Apr 11, 2023
This was referenced Apr 11, 2023
|
@lgfa29 Any word on when this will be released? |
|
@chrispruitt I hope to be working on this over the next days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raising as WIP for initial feedback. Deps will certainly need sorting before this is ready for merge.