Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for HTTP basic auth #189

Merged
merged 2 commits into from
Jan 18, 2021
Merged

Add support for HTTP basic auth #189

merged 2 commits into from
Jan 18, 2021

Conversation

lgfa29
Copy link
Contributor

@lgfa29 lgfa29 commented Jan 15, 2021

This PR adds the http_auth provider config key to allow passing HTTP basic auth settings to the Nomad client.

Closes #180

@lgfa29 lgfa29 requested review from cgbaker and jrasell January 15, 2021 21:19
@lgfa29 lgfa29 force-pushed the add-http-basic-auth branch from 69f66d6 to c7d6866 Compare January 15, 2021 21:22
jrasell
jrasell approved these changes Jan 18, 2021
View reviewed changes
Copy link
Member

@jrasell jrasell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lgfa29 lgfa29 merged commit 4dffb7e into master Jan 18, 2021
@lgfa29 lgfa29 deleted the add-http-basic-auth branch January 18, 2021 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrasell jrasell jrasell approved these changes

@cgbaker cgbaker Awaiting requested review from cgbaker

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HTTP Basic Auth Support
2 participants
@lgfa29 @jrasell