datasource: add Nomad scheduler config data source. #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgbaker
previously approved these changes
Nov 2, 2020
There was a problem hiding this comment.
cool.
the standard trick that we've used for testing these is a resource to set, then a dependent datasource should see the new value. e.g.,
https://github.com/hashicorp/terraform-provider-nomad/blob/master/nomad/data_source_acl_policy_test.go#L36-L48
did that not work here?
Co-authored-by: Chris Baker <1675087+cgbaker@users.noreply.github.com>
lgfa29
suggested changes
Nov 2, 2020
lgfa29
approved these changes
Nov 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are no tests, because they unfortunately clash with the scheduler config resource, which updates the config values meaning the datasource tests have a race condition output with that. I'll think how to better approach this, but it highlights why this resource should be used carefully.
The dependancy update is unrelated to this change, but is needed as a result of 438a0b8 so is included.