Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/volume: add "mount_options" argument to volume resource. #147

Merged
merged 2 commits into from
Aug 28, 2020

Conversation

jrasell
Copy link
Member

@jrasell jrasell commented Aug 27, 2020

closes #145

@jrasell jrasell requested review from lgfa29 and cgbaker August 27, 2020 14:23
@jrasell jrasell self-assigned this Aug 27, 2020
@jrasell jrasell changed the title F gh 145 resource/volume: add "mount_options" argument to volume resource. Aug 27, 2020
cgbaker
cgbaker previously approved these changes Aug 27, 2020
Copy link
Contributor

@cgbaker cgbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

lgfa29
lgfa29 previously approved these changes Aug 27, 2020
@jrasell jrasell dismissed stale reviews from lgfa29 and cgbaker via a4ba4a6 August 27, 2020 17:22
@jrasell jrasell merged commit 7dee079 into master Aug 28, 2020
@jrasell jrasell deleted the f-gh-145 branch August 28, 2020 13:01
jrasell added a commit that referenced this pull request Aug 28, 2020
jrasell added a commit that referenced this pull request Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement mount_options for nomad volume resource
5 participants