Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

acl_auth_method: add token name format parameter #394

Closed
jrasell opened this issue Nov 28, 2023 · 3 comments · Fixed by #403
Closed

acl_auth_method: add token name format parameter #394

jrasell opened this issue Nov 28, 2023 · 3 comments · Fixed by #403
Assignees
@jrasell
Labels
stage/accepted

Comments

@jrasell
Copy link
Member

jrasell commented Nov 28, 2023

Nomad PR hashicorp/nomad#19135 added support for an optional token name format parameter within an ACL authentication method. The Nomad Terraform provider should be updated to support this.
@jrasell jrasell self-assigned this Nov 28, 2023
@the-nando
Copy link
Contributor

the-nando commented Dec 13, 2023 •
edited
Loading

hey @jrasell 😄 did you get a chance to look at this? I can put together a PR otherwise

@jrasell
Copy link
Member Author

jrasell commented Dec 13, 2023

Hi @the-nando; I have not got around to this. If you have the ability to raise a PR with this addition, that would be amazing. If you have any questions, feel free to ping me about it.

@the-nando the-nando mentioned this issue Dec 13, 2023
Merged
@the-nando
Copy link
Contributor

I had to update a couple of unrelated tests after the bump to 1.7.1. The OSS acceptance test run clean: https://github.com/the-nando/terraform-provider-nomad/actions/runs/7206010755/job/19630025904
Could you please have a look if it looks ok to you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jrasell jrasell

Labels
stage/accepted
Projects
None yet
Milestone
No milestone
2 participants
@jrasell @the-nando