Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for TLS Certificates as Strings #181

Closed
thebeanogamer opened this issue Dec 29, 2020 · 0 comments · Fixed by #184
Closed

Support for TLS Certificates as Strings #181

thebeanogamer opened this issue Dec 29, 2020 · 0 comments · Fixed by #184
Assignees

Comments

@thebeanogamer
Copy link

Currently, the Consul provider supports being given certificates for Mutual TLS inline (in a variable) or as a file path, in its cert_pem and key_pem fields. The Nomad provider lacks this functionality, as certificates can only be provided as paths. Matching this functionality would be very useful for environments like Terraform Cloud, where the only way to put a file onto a system would be to include it in version control.

This functionality was implemented in hashicorp/terraform-provider-consul#220, and whilst I plan to look at copying these changes to a PR on this repository, my Go and Terraform Provider Development experience is very limited, so that may not be a time efficient solution. Notably, the structure of unit tests seems to be a bit different on that repository, so this will need to be examined when migrating these changes. If the plan is to implement the same or very similar code to the aforementioned PR, I think it would be appropriate for @lawliet89 to give their approval, as it is ultimately their work.

As I say, I plan to look at making these changes myself, but I am happy to test someone else's implementation if they develop one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants