data.kubernetes_nodes should include annotations

[hcsaustrup]

Description

Please consider returning annotations in the kubernetes_nodes data source. Currently annotations are returned, but always as an empty object ({}).

[arybolovlev]

Hi @hcsaustrup,

Thank you for reporting this issue. I was able to reproduce it and isolate a piece of code where it happens.

I am going to bring this up during our triage session so we can evaluate this issue.

Thanks!

[arybolovlev]

To add a bit more context here.

• There is a function flattenMetadata that covers multiple use cases when it comes to flattening received metadata.
• This function aims to cover two use cases -- (1) regular Kubernetes object, when we cut out any labels and annotations whose key names end with kubernetes.io(more information in out documentation here), (2) object templates, when we don't cut out any labels and annotations.
• Due to the nature of the kubernetes_nodes data source(here we pass a prefix), it falls under the second scenario, but it covers only object templates and thus fails for the discussed data source.

We need to refactor the flattenMetadata function and basically split in into smaller functions to cover different scenarios.

[arybolovlev]

@hcsaustrup, in your case, do you expect to see all annotations and labels in this data source or cutting out kubernetes.io ones sounds right?

[hcsaustrup]

I'm primarily looking for custom annotations and labels we added ourselves - but if it's not a problem, it would be nice to have all of them available, just in case.