Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Assured Workloads #8673

Closed
rileykarson opened this issue Mar 11, 2021 · 7 comments
Closed

Add support for Assured Workloads #8673

rileykarson opened this issue Mar 11, 2021 · 7 comments
Assignees
Labels
enhancement forward/review In review; remove label to forward new-resource priority/2 service/assuredworkloads size/m tpgtools Issues related to the tpgtools generator

Comments

@rileykarson
Copy link
Collaborator

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

New or Affected Resource(s)

  • google_assured_workloads_workload

Potential Terraform Configuration

resource "google_assured_workloads_workload" "my_workload" {
  name = "my-workload"
  organization = "1234567890"
  location = "us-central1" # it's unclear what's actually expected for this value

  display_name = "My Workload"
  compliance_regime = "FEDRAMP_HIGH"
  billing_account = "billingAccounts/1234567890"

  resources {
    resource_id = "1234567890" # (project number)
    resource_type = "CONSUMER_PROJECT"
  }

  resources {
    resource_id = "0987654321"
    resource_type = "ENCRYPTION_KEYS_PROJECT"
  }
}

References

@ghost ghost added the enhancement label Mar 11, 2021
@rileykarson rileykarson added new-resource size/m tpgtools Issues related to the tpgtools generator labels Mar 15, 2021
@rileykarson rileykarson added this to the Near-Term Goals milestone Mar 15, 2021
@rileykarson
Copy link
Collaborator Author

note: DCL support is available, pending release

@rileykarson
Copy link
Collaborator Author

rileykarson commented Apr 19, 2021

Unassigning- no DCL support yet, I'd misread the status. @melinath, I'm gonna swap this with #6694 which is available.

@ScottSuarez
Copy link
Collaborator

closed with GoogleCloudPlatform/magic-modules#4936

@pgoldtho
Copy link

@ScottSuarez should this be reopened since #4936 was reverted?

I'm guessing it failed in testing. I encountered a couple of issues while testing a local build. The destroy action fails because the Cloud Resource Manager API is not enabled for the workload.

Error: Error deleting Workload: googleapi: Error 403: Cloud Resource Manager API has not been used in project before or it is disabled. 

I was able to delete the resource after manually enabling the API but it required 2 attempts. The first attempt failed with:

Error: Error deleting Workload: failed to delete Workload: googleapi: Error 400: Workload contains projects or other resources that are not deleted.
Details:
[
  {
    "@type": "type.googleapis.com/google.rpc.ErrorInfo",
    "domain": "assuredworkloads.googleapis.com",
    "reason": "ERROR_CODE_WORKLOAD_NOT_EMPTY"
  }
]

I was able to delete the workload by rerunning terraform apply. I'm assuming that is because projects associated with the workload had been marked for deletion in the first run.

I suspect these are issues with the Assured Workload API rather than its terraform wrapper.

@ScottSuarez
Copy link
Collaborator

That revert was specifically for release 3.75 but we will have to revert it for 3.76 as well. Assured workloads api is rapidly developing and some assumptions we made broke our upstream implementation as the api has mutated.

@ScottSuarez
Copy link
Collaborator

It will be available in 3.76 pending no new issue.

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 15, 2021
@github-actions github-actions bot added forward/review In review; remove label to forward service/assuredworkloads labels Jan 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement forward/review In review; remove label to forward new-resource priority/2 service/assuredworkloads size/m tpgtools Issues related to the tpgtools generator
Projects
None yet
Development

No branches or pull requests

6 participants