Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Cloud SQL Query Insights #8449

Closed
jcanseco opened this issue Feb 11, 2021 · 4 comments
Closed

Support for Cloud SQL Query Insights #8449

jcanseco opened this issue Feb 11, 2021 · 4 comments
Labels
Milestone

Comments

@jcanseco
Copy link
Contributor

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

Cloud SQL for PostgreSQL recently added a feature known as Query Insights. The API docs for Cloud SQL instances don't yet document how to configure this feature via the API, but the API presumably exposes a settings.insightsConfig field based on the sample request body on this page.

New or Affected Resource(s)

  • google_sql_database_instance

Potential Terraform Configuration

resource "google_sql_database_instance" "my-instance" {
  name             = "my-instance"
  database_version = "POSTGRES_11"
  region           = "us-central1"

  settings {
    tier = "db-f1-micro"

    insights_config {
      query_insights_enabled = true
      query_string_length = 1024
      record_application_tags = true
      record_client_address = true
    }
  }
}

Note that the schema suggested by the above configuration is not a requirement but only a suggestion based on disparate information on how the API exposes the feature.

References

@ghost ghost added the enhancement label Feb 11, 2021
@rileykarson rileykarson added this to the Goals milestone Feb 16, 2021
@j-martin
Copy link

This is an issue for us as changing the instance(s) configuration via terraform disableds Query Insights and forces a restart.

@Chupaka
Copy link
Contributor

Chupaka commented Feb 25, 2021

@rileykarson
Copy link
Collaborator

Thanks @Chupaka!

@ghost
Copy link

ghost commented Mar 29, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 29, 2021
@github-actions github-actions bot added forward/review In review; remove label to forward service/sqladmin-cp labels Jan 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants