Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add backup retention field to Cloud SQL #7961

Closed
schirayu opened this issue Dec 7, 2020 · 1 comment · Fixed by GoogleCloudPlatform/magic-modules#4385, #8582 or hashicorp/terraform-provider-google-beta#3010

Comments

@schirayu
Copy link

schirayu commented Dec 7, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

The gcloud command and the API seem to support a retained-backups-count field, which allows us to choose how many automated backups we would like to retain. See https://cloud.google.com/sdk/gcloud/reference/beta/sql/instances/create#--retained-backups-count. The current default is 7 days.

The google_sql_database_instance resource in Terraform does not support this field yet. We need this field exposed since 7 days of retention is not enough for us. To achieve this, we are having to write cron jobs, which brings in issues related to managing an extra infrastructure piece in production. It would be great if this was supported directly via Terraform.

New or Affected Resource(s)

  • google_sql_database_instance

Potential Terraform Configuration

# Propose what you think the configuration to take advantage of this feature should look like.
# We may not use it verbatim, but it's helpful in understanding your intent.
settings.backup_configuration.retained_backups_count=<number between 1-365 as per current support>

References

  • b/175914398
@ghost
Copy link

ghost commented Apr 1, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Apr 1, 2021
@github-actions github-actions bot added forward/review In review; remove label to forward service/sqladmin-cp labels Jan 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.