Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for warm up requests in google_app_engine_standard_app_version #6904

Assignees
Labels

Comments

@maroux
Copy link
Contributor

maroux commented Jul 31, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

Unable to use google_app_engine_service_split_traffic because that requires warm up requests to be enabled and google_app_engine_standard_app_version doesn't provide any way to enable that.

New or Affected Resource(s)

  • google_app_engine_service_split_traffic
  • google_app_engine_standard_app_version

Potential Terraform Configuration

resource "google_app_engine_standard_app_version" "service" {
  service    = "service"
  runtime    = "go112"
  version_id = "v1"

  deployment {
    zip {
      source_url = "..."
    }
  }

  lifecycle {
    create_before_destroy = true
  }

  noop_on_destroy = true

  timeouts {
    create = "10m"
  }
}

resource "google_app_engine_service_split_traffic" "service" {
  service = google_app_engine_standard_app_version.service.service

  migrate_traffic = true

  split {
    shard_by = "IP"

    allocations = {
      (google_app_engine_standard_app_version.service.version_id) = 1.0
    }
  }
}

Fails with error:

Error: Error creating ServiceSplitTraffic: googleapi: Error 400: Invalid request.
Details:
[
  {
    "@type": "type.googleapis.com/google.rpc.BadRequest",
    "fieldViolations": [
      {
        "description": "Warmup requests must be enabled for all versions that will gain additional traffic as a result of the traffic migration.",
        "field": "service.split.allocations[v0-3-1]"
      }
    ]
  }
]
@ghost ghost added the enhancement label Jul 31, 2020
@maroux maroux changed the title Unable to use google_app_engine_service_split_traffic Add support for warm up requests in google_app_engine_standard_app_version Jul 31, 2020
@ghost
Copy link

ghost commented Sep 6, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Sep 6, 2020
@github-actions github-actions bot added forward/review In review; remove label to forward service/appengine labels Jan 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.