Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

google_notebooks_location is not functional #21516

Open
roaks3 opened this issue Feb 20, 2025 · 1 comment
Open

google_notebooks_location is not functional #21516

roaks3 opened this issue Feb 20, 2025 · 1 comment
Labels
breaking-change bug forward/exempt Never forward this issue service/notebooks
Milestone
Future Major Release

Comments

@roaks3
Copy link
Collaborator

roaks3 commented Feb 20, 2025

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request.
  • Please do not leave +1 or me too comments, they generate extra noise for issue followers and do not help prioritize the request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.
  • If an issue is assigned to a user, that user is claiming responsibility for the issue.
  • Customers working with a Google Technical Account Manager or Customer Engineer can ask them to reach out internally to expedite investigation and resolution of this issue.

Terraform Version & Provider Version(s)

Terraform vX.X.X
on

  • provider registry.terraform.io/hashicorp/google vX.X.X
  • provider registry.terraform.io/hashicorp/google-beta vX.X.X

Affected Resource(s)

google_notebooks_location

Terraform Configuration



Debug Output


No response


Expected Behavior


It should not exist


Actual Behavior


No response


Steps to reproduce


    

  1. terraform apply
    2. 



Important Factoids


Resource is deprecated with GoogleCloudPlatform/magic-modules#11972 because it is not an actual resource, and we didn't want to immediately remove it in case that causes problems for users.


We should remove it in the next major.


More info from the PR:




This was added in GoogleCloudPlatform/magic-modules#3620






I believe it was meant to only be used for ResourceRefs of the other resources, and not to be an actual resource itself. I was not able to find working create/delete endpoints, the resource is not used in any tests, and there are no issues referencing it. I also tried to provision the resource locally, and received a 404:




google_notebooks_location.loc: Creating...
╷
│ Error: Error creating Location: googleapi: got HTTP response code 404 with body: <!DOCTYPE html>
│ <html lang=en>
│   <meta charset=utf-8>
│   <meta name=viewport content="initial-scale=1, minimum-scale=1, width=device-width">
│   <title>Error 404 (Not Found)!!1</title>
│   <style>
│     *{margin:0;padding:0}html,code{font:15px/22px arial,sans-serif}html{background:#fff;color:#222;padding:15px}body{margin:7% auto 0;max-width:390px;min-height:180px;padding:30px 0 15px}* > body{background:url(//www.google.com/images/errors/robot.png) 100% 5px no-repeat;padding-right:205px}p{margin:11px 0 22px;overflow:hidden}ins{color:#777;text-decoration:none}a img{border:0}@media screen and (max-width:772px){body{background:none;margin-top:0;max-width:none;padding-right:0}}#logo{background:url(//www.google.com/images/branding/googlelogo/1x/googlelogo_color_150x54dp.png) no-repeat;margin-left:-5px}@media only screen and (min-resolution:192dpi){#logo{background:url(//www.google.com/images/branding/googlelogo/2x/googlelogo_color_150x54dp.png) no-repeat 0% 0%/100% 100%;-moz-border-image:url(//www.google.com/images/branding/googlelogo/2x/googlelogo_color_150x54dp.png) 0}}@media only screen and (-webkit-min-device-pixel-ratio:2){#logo{background:url(//www.google.com/images/branding/googlelogo/2x/googlelogo_color_150x54dp.png) no-repeat;-webkit-background-size:100% 100%}}#logo{display:inline-block;height:54px;width:150px}
│   </style>
│   <a href=//www.google.com/><span id=logo aria-label=Google></span></a>
│   <p><b>404.</b> <ins>That’s an error.</ins>
│   <p>The requested URL <code>/v1/projects/ryanoaksnightly2/locations?alt=json</code> was not found on this server.  <ins>That’s all we know.</ins>



References


No response

      		
    

      
  





        



            

              
            

        

      


      
    








      

    



      

  
            

    

      
    

    


      

          @roaks3
roaks3




          added
  the 

  bug

 label


      Feb 20, 2025

    

  



    

    

      
    

    


      

          @github-actions
github-actions
bot



            added
      

  forward/review

  In review; remove label to forward

      

  service/notebooks


  labels


      Feb 20, 2025

    

  



    

    

      
    

    


      

          @roaks3
roaks3




            added
      

  breaking-change


      

  forward/exempt

  Never forward this issue

    and removed
      

  forward/review

  In review; remove label to forward

  labels


      Feb 20, 2025

    

  








      

  
      



  

  @roaks3





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
    Collaborator


      

  Author


  


  

    

      

      
            roaks3
  

      

      

      commented


        Feb 20, 2025


      
    


  





      


        


  
    

      
          
I'm not forwarding this one for now because I assume our team will handle the removal (most likely just GoogleCloudPlatform/magic-modules@fff54d2), and it is expected to happen in a major release.


Feel free to adjust if we do want to forward it.

      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
          

  

    
  


  

      

    @roaks3
roaks3



    mentioned this issue
    
      Feb 20, 2025
    





  


  

      
   Merged

  







  




    

    

      
    

    


      

          @zli82016
zli82016




          added this to the   Future Major Release milestone


      Feb 20, 2025

    

  












  
  

    

      

  





  




  
  

              

  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  



  






  
                  




    

  


      
  

    Assignees
  



        

    No one assigned







      


  


  

    Labels
  



    

      

    breaking-change

  

    bug

  

    forward/exempt

  Never forward this issue
  

    service/notebooks









      

  

    

        

    Projects
  


        




    None yet




  



      


  

    
  

    Milestone
  


      
    
  
    Future Major Release
  





    
      
          
  

    

      

        
          

            
    

    Development
  




              
    
No branches or pull requests







        
      

    

  


      

    

  
      

  

    

      2 participants
    

    

        
          @roaks3 
        
          @zli82016