Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

google_storage_bucket - Change in lifecycle_rule's condition is not recognised #10015

Closed
Assignees
Labels
bug forward/review In review; remove label to forward service/storage

Comments

@ilicmilan
Copy link
Contributor

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request.
  • Please do not leave +1 or me too comments, they generate extra noise for issue followers and do not help prioritize the request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.
  • If an issue is assigned to the modular-magician user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If an issue is assigned to a user, that user is claiming responsibility for the issue. If an issue is assigned to hashibot, a community member has claimed the issue already.

Terraform Version

Terraform v0.15.3
on darwin_amd64

  • provider registry.terraform.io/hashicorp/google v3.82.0
  • provider registry.terraform.io/hashicorp/google-beta v3.82.0

Affected Resource(s)

  • google_storage_bucket

Terraform Configuration Files

resource "google_storage_bucket" "bucket" {
  name          = "my-bucket"
  location      = "europe-west1"
  storage_class = "STANDARD"

  versioning {
    enabled = true
  }

  lifecycle_rule {
    action {
      type = "Delete"
    }
    condition {
      days_since_noncurrent_time = 30
      with_state                 = "ARCHIVED"
    }
  }
}

Expected Behavior

I decided to update lifecycle_rule's condition days_since_noncurrent_time to 35.
I expected Terraform to recognize the change.

Actual Behavior

No changes were identified.

Steps to Reproduce

resource "google_storage_bucket" "bucket" {
  name          = "my-bucket"
  location      = "europe-west1"
  storage_class = "STANDARD"

  versioning {
    enabled = true
  }

  lifecycle_rule {
    action {
      type = "Delete"
    }
    condition {
      days_since_noncurrent_time = 30
      with_state                 = "ARCHIVED"
    }
  }
}
  1. Run terraform apply
  2. Change days_since_noncurrent_time to 35.
  3. Run terraform plan or terraform apply again.
@ilicmilan
Copy link
Contributor Author

Thanks, @edwardmedia for fixing it quickly!
Not that I need it right now, but looking at the fix and possible condition options, seems that we are still missing a few checks: days_since_custom_time, custom_time_before, noncurrent_time_before.

@github-actions
Copy link

github-actions bot commented Oct 9, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 9, 2021
@github-actions github-actions bot added service/storage forward/review In review; remove label to forward labels Jan 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug forward/review In review; remove label to forward service/storage
Projects
None yet
2 participants