From 1577c15c17f2436d056572112cb4de638a17c907 Mon Sep 17 00:00:00 2001 From: The Magician Date: Thu, 30 Jan 2025 09:25:14 -0800 Subject: [PATCH] Allow parallelization of per instance config deletions by not locking on the IGM (#12864) (#21095) [upstream:2cabee584b77ec9895995b852101ae2b03853cff] Signed-off-by: Modular Magician --- .changelog/12864.txt | 3 +++ .../services/compute/resource_compute_per_instance_config.go | 2 +- .../compute/resource_compute_region_per_instance_config.go | 2 +- 3 files changed, 5 insertions(+), 2 deletions(-) create mode 100644 .changelog/12864.txt diff --git a/.changelog/12864.txt b/.changelog/12864.txt new file mode 100644 index 00000000000..feffb614b81 --- /dev/null +++ b/.changelog/12864.txt @@ -0,0 +1,3 @@ +```release-note:enhancement +compute: allow parallelization of `google_compute_per_instance_config` and `google_compute_region_per_instance_config` deletions by not locking on the parent resource, but including instance name. +``` \ No newline at end of file diff --git a/google/services/compute/resource_compute_per_instance_config.go b/google/services/compute/resource_compute_per_instance_config.go index e5e9885d2b9..7d5e8d8220e 100644 --- a/google/services/compute/resource_compute_per_instance_config.go +++ b/google/services/compute/resource_compute_per_instance_config.go @@ -579,7 +579,7 @@ func resourceComputePerInstanceConfigDelete(d *schema.ResourceData, meta interfa return err } - lockName, err := tpgresource.ReplaceVars(d, config, "instanceGroupManager/{{project}}/{{zone}}/{{instance_group_manager}}") + lockName, err := tpgresource.ReplaceVars(d, config, "instanceGroupManager/{{project}}/{{zone}}/{{instance_group_manager}}/{{name}}") if err != nil { return err } diff --git a/google/services/compute/resource_compute_region_per_instance_config.go b/google/services/compute/resource_compute_region_per_instance_config.go index 0fc5a1907c5..5ee5adfe30f 100644 --- a/google/services/compute/resource_compute_region_per_instance_config.go +++ b/google/services/compute/resource_compute_region_per_instance_config.go @@ -579,7 +579,7 @@ func resourceComputeRegionPerInstanceConfigDelete(d *schema.ResourceData, meta i return err } - lockName, err := tpgresource.ReplaceVars(d, config, "instanceGroupManager/{{project}}/{{region}}/{{region_instance_group_manager}}") + lockName, err := tpgresource.ReplaceVars(d, config, "instanceGroupManager/{{project}}/{{region}}/{{region_instance_group_manager}}/{{name}}") if err != nil { return err }