Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request for app_service and function_app #756

Closed
kevinneufeld opened this issue Jan 25, 2018 · 5 comments
Closed

Feature Request for app_service and function_app #756

kevinneufeld opened this issue Jan 25, 2018 · 5 comments

Comments

@kevinneufeld
Copy link

I would be great to see on both the following additions:

  • add {httpsOnly:true}
{
   "apiVersion": "2016-08-01",
    "type": "Microsoft.Web/sites",
    "name": "[variables('functionAppName')]",
    "location": "[resourceGroup().location]",
    "kind": "functionapp",
    "properties": {
        "serverFarmId": "[resourceId('Microsoft.Web/serverfarms', variables('hostingPlanName'))]",
         "httpsOnly": true
     }
}
  • add and bind certificates from keyvault to them.
{
    "type": "Microsoft.Web/certificates",
    "name": "[parameters('keyvaultSslCertificateName')]",
    "apiVersion": "2016-03-01",
    "location": "[resourceGroup().location]",
    "properties": {
        "keyVaultId": "[parameters('keyVaultId')]",
        "keyVaultSecretName": "[parameters('keyvaultSslCertificateName')]",
        "serverFarmId": "[resourceId('Microsoft.Web/serverfarms', variables('hostingPlanName'))]"
    },
    "dependsOn": [
        "[concat('Microsoft.Web/sites/',variables('functionAppName'))]"
    ]
},
{
    "type": "Microsoft.Web/sites/hostnameBindings",
    "name": "[concat(variables('functionAppName'), '/', parameters('appServiceCustomHostname'))]",
    "apiVersion": "2016-03-01",
    "location": "[resourceGroup().location]",
    "properties": {
        "sslState": "SniEnabled",
        "thumbprint": "[reference(resourceId('Microsoft.Web/certificates', parameters('keyvaultSslCertificateName'))).Thumbprint]"
    },
    "dependsOn": [
        "[concat('Microsoft.Web/certificates/',parameters('keyvaultSslCertificateName'))]"
    ]
}
@tombuildsstuff tombuildsstuff added this to the 1.1.2 milestone Feb 6, 2018
@tombuildsstuff tombuildsstuff modified the milestones: 1.1.2, 1.1.3 Feb 15, 2018
@pixelicous
Copy link

@tombuildsstuff the whole properties object is missing.. too bad.. there is the app settings, connection strings and site config..almost everything is there.. i'd also add msi support ..

@tombuildsstuff tombuildsstuff modified the milestones: 1.1.3, 1.1.4 Feb 28, 2018
@tombuildsstuff tombuildsstuff modified the milestones: 1.3.0, 1.4.0 Mar 15, 2018
@metacpp metacpp assigned JunyiYi and unassigned metacpp Apr 3, 2018
@cscheib
Copy link

cscheib commented Apr 4, 2018

Just +1'ing this. I make heavy use of the Windows App Services, and would like to manage all of the attributes possible. HTTPS Only is, in particular, of large interest.

@tombuildsstuff
Copy link
Contributor

hey @kevinneufeld @pixelicous @cscheib

Thanks for opening this issue :)

I've opened PR #1080 which includes support for setting the https_only on App Service, App Service Slots and Function apps.

Thanks!

@tombuildsstuff
Copy link
Contributor

Fixed in #1080

@ghost
Copy link

ghost commented Mar 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost unassigned JunyiYi Mar 31, 2020
@ghost ghost locked and limited conversation to collaborators Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants