Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual deletion of S3 bucket CORS does not force terraform to update CORS for bucket. #4849

Closed
jessegonzalez opened this issue Jun 15, 2018 · 4 comments · Fixed by #4887
Closed
Labels
bug Addresses a defect in current functionality. service/s3 Issues and PRs that pertain to the s3 service.
Milestone

Comments

@jessegonzalez
Copy link
Contributor

jessegonzalez commented Jun 15, 2018

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform Version

Terraform v0.11.7
+ provider.aws v1.23.0

Affected Resource(s)

  • aws_s3_bucket

Terraform Configuration Files

provider "aws" {
  region  = "us-east-1"
  version = " ~> 1.23.0"
  profile = "dev"
}

resource "aws_s3_bucket" "cors-testing-terraform" {
  bucket = "cors-testing-terraform"

  cors_rule {
    allowed_origins = ["some.fqdn", "another.fqdn"]
    allowed_methods = ["GET"]
    allowed_headers = ["*"]
    max_age_seconds = 3000
  }
}

Debug Output

Panic Output

Expected Behavior

After having deleted CORS configuration for an S3 bucket in the AWS console, terraform plan/apply should recognize the change and apply CORS configuration as defined.

Actual Behavior

CORS is left unconfigured.

Steps to Reproduce

  1. terraform apply
  2. Update S3 bucket and delete CORS configuration
  3. terraform apply

Important Factoids

Other changes to the CORS configuration via console , i.e. adding AllowedOrigin or AllowHeader attributes are recognized and adjusted.

References

  • None
@jessegonzalez
Copy link
Contributor Author

I've created a PR for this issue: #4887

@bflad bflad added bug Addresses a defect in current functionality. service/s3 Issues and PRs that pertain to the s3 service. labels Jun 21, 2018
@bflad bflad added this to the v1.24.0 milestone Jun 21, 2018
@bflad
Copy link
Contributor

bflad commented Jun 21, 2018

The fix for this has been merged into master and will release with version 1.24.0 of the AWS provider, very shortly.

@bflad
Copy link
Contributor

bflad commented Jun 25, 2018

This has been released in version 1.24.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 5, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/s3 Issues and PRs that pertain to the s3 service.
Projects
None yet
2 participants