Expose server version via LSP #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f47e514 to
f2a5e49
Compare
appilon
suggested changes
Nov 23, 2020
| @@ -166,6 +166,11 @@ func (svc *service) Assigner() (jrpc2.Assigner, error) { | |||
| ctx = lsctx.WithRootModuleManager(ctx, svc.modMgr) | |||
| ctx = lsctx.WithRootModuleLoader(ctx, rmLoader) | |||
|
|
|||
| version, ok := lsctx.LanguageServerVersion(svc.srvCtx) | |||
There was a problem hiding this comment.
I don't get the cycle here?
There was a problem hiding this comment.
This is because the server starts with its own empty context, for better or worse:
https://github.com/creachadair/jrpc2/blob/3fb8081ec1bde4adba1b3a57dff458328a8ea769/server.go#L304
You could argue both sides - it's good for isolation - you don't get to inherit things by accident, but also it can make it more verbose 🤷♂️
appilon
approved these changes
Nov 23, 2020
| @@ -166,6 +166,11 @@ func (svc *service) Assigner() (jrpc2.Assigner, error) { | |||
| ctx = lsctx.WithRootModuleManager(ctx, svc.modMgr) | |||
| ctx = lsctx.WithRootModuleLoader(ctx, rmLoader) | |||
|
|
|||
| version, ok := lsctx.LanguageServerVersion(svc.srvCtx) | |||
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6