-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Automate releasing via bob #1167
Conversation
959113e
to
c6c0ef6
Compare
c6c0ef6
to
4ac2352
Compare
4ac2352
to
72613c3
Compare
55998d5
to
7cf2ff3
Compare
Can we run the staging and production back to back? Or do we have to wait until staging completes before running production? |
I have added the dependency on line 49 https://github.com/hashicorp/terraform-ls/pull/1167/files#diff-87db21a973eed4fef5f32b267aa60fcee5cbdf03c67fafdc2a9b553bb0b15f34R49 but it's not strictly necessary. The real "awkward part" though about the whole process is that both I discussed this problem more with the RelEng team and they are planning to remove the requirement of Strictly speaking - and to answer your question - it should be fine because the |
Thanks for the additional context. Should we add a note to the README that we need to wait until the staging workflow has succeeded and the artifacts have landed in the staging bucket (also a good time to manually test the build) before approving the production workflow? |
7cf2ff3
to
a7a63d3
Compare
@dbanck added a step for this in the instructions, PTAL |
79b29d4
to
ebf5411
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Context
Releasing currently requires a number of additional steps outside of GitHub. For a simple project with simple release pipeline such as this one, there is no strong benefit to do multi-staged releasing, as some other bigger projects do.
Proposal
Simplify release process by moving promotion steps into a GHA workflow.
TODO
tf-editor-exp-ci-bot
tobob
repoBOB_GITHUB_TOKEN