You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The implementation doesn't have to be perfect nor it needs to cover 100% of cases that Terraform Core covers, as it's meant to be mostly UX improvement picking a particular icon, not a critical part of the API, but I think we should at least attempt to mimic what core does. Improving the detection later should also be relatively easy given the testability of something that takes just single string as input.
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.
Extract (in the form of some re-implementation and copy-pasting) the detection logic from Terraform Core https://github.com/hashicorp/terraform/blob/332ea1f233891e45bd274e714ab8e4e11c79dc95/internal/addrs/module_source.go#L191-L268
The implementation doesn't have to be perfect nor it needs to cover 100% of cases that Terraform Core covers, as it's meant to be mostly UX improvement picking a particular icon, not a critical part of the API, but I think we should at least attempt to mimic what core does. Improving the detection later should also be relatively easy given the testability of something that takes just single string as input.
Originally posted by @radeksimko in #632 (comment)
The text was updated successfully, but these errors were encountered: