Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Terraform Module Source Address parsing library #647

Closed
jpogran opened this issue Sep 23, 2021 · 2 comments
Closed

Create Terraform Module Source Address parsing library #647

jpogran opened this issue Sep 23, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@jpogran
Copy link
Contributor

jpogran commented Sep 23, 2021

Extract (in the form of some re-implementation and copy-pasting) the detection logic from Terraform Core https://github.com/hashicorp/terraform/blob/332ea1f233891e45bd274e714ab8e4e11c79dc95/internal/addrs/module_source.go#L191-L268

The implementation doesn't have to be perfect nor it needs to cover 100% of cases that Terraform Core covers, as it's meant to be mostly UX improvement picking a particular icon, not a critical part of the API, but I think we should at least attempt to mimic what core does. Improving the detection later should also be relatively easy given the testability of something that takes just single string as input.

Originally posted by @radeksimko in #632 (comment)

@radeksimko radeksimko added the enhancement New feature or request label Sep 23, 2021
@dbanck
Copy link
Member

dbanck commented Apr 26, 2022

Closed via hashicorp/terraform-registry-address#7

@dbanck dbanck closed this as completed Apr 26, 2022
@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants