Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ServerInfo identification of the LS #6

Closed
radeksimko opened this issue Feb 21, 2020 · 2 comments · Fixed by #318
Closed

Add ServerInfo identification of the LS #6

radeksimko opened this issue Feb 21, 2020 · 2 comments · Fixed by #318
Labels
good first issue Good for newcomers

Comments

@radeksimko
Copy link
Member

https://microsoft.github.io/language-server-protocol/specifications/specification-current/#initialize

interface InitializeResult {
	/**
	 * The capabilities the language server provides.
	 */
	capabilities: ServerCapabilities;

	/**
	 * Information about the server.
	 *
	 * @since 3.15.0
	 */
	serverInfo?: {
		/**
		 * The name of the server as defined by the server.
		 */
		name: string;

		/**
		 * The server's version as defined by the server.
		 */
		version?: string;
	};
}
@radeksimko radeksimko changed the title Decide on ServerInfo identification of the LS Add ServerInfo identification of the LS Feb 21, 2020
@radeksimko radeksimko added this to the v0.1.0 milestone Mar 24, 2020
@radeksimko
Copy link
Member Author

This requires some upstream changes https://github.com/sourcegraph/go-lsp/blob/b19bb38222e24b57a93b803229b83f1eb113095d/service.go#L212-L214 or us switching to a fork or a different library altogether.

@radeksimko radeksimko removed this from the v0.1.0 milestone Mar 24, 2020
@radeksimko radeksimko added the good first issue Good for newcomers label Jul 22, 2020
@ghost
Copy link

ghost commented Dec 24, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the context necessary to investigate further.

@ghost ghost locked as resolved and limited conversation to collaborators Dec 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant