Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include "Verified" provider schemas in the LS builds. #321

Closed
paultyng opened this issue Nov 30, 2020 · 2 comments · Fixed by #341
Closed

Include "Verified" provider schemas in the LS builds. #321

paultyng opened this issue Nov 30, 2020 · 2 comments · Fixed by #341
Assignees
Labels
enhancement New feature or request

Comments

@paultyng
Copy link
Contributor

We should expand preloaded schemas from #302 to include both "Official" and "Verified" assuming the resulting binary is not prohibitively large and performance is not adversely affected.

@radeksimko
Copy link
Member

We discussed this before, but I'll just note it here for posterity:

In addition to the binary size, the codebase size is also a concern, so as part of this work we should consider generating schemas as part of the release. Sadly this will make builds practically unreproducible, but I think it's ok trade-off for the value added and considering this is mostly a temporary solution until #193 is resolved.

@ghost
Copy link

ghost commented Feb 5, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the context necessary to investigate further.

@ghost ghost locked as resolved and limited conversation to collaborators Feb 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants