Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract HCL Syntax #7

Merged
merged 5 commits into from
Mar 4, 2022
Merged

Extract HCL Syntax #7

merged 5 commits into from
Mar 4, 2022

Conversation

jpogran
Copy link
Contributor

@jpogran jpogran commented Feb 28, 2022 •
edited
Loading

  • Update Terraform grammar to latest from hashicorp/vscode-terraform@bb95e28
  • Move grammar to standard syntaxes directory
  • Extract HCL grammar to dedicated file
  • Configure Terraform grammar to inherit from HCL grammar
  • Add HCL snapshot tests

@jpogran jpogran self-assigned this Feb 28, 2022
@jpogran jpogran added the enhancement New feature or request label Feb 28, 2022
@jpogran jpogran added this to the 0.1.0 milestone Feb 28, 2022
@jpogran jpogran linked an issue Feb 28, 2022 that may be closed by this pull request
Extract HCL2 grammar from terraform to new hcl grammar file #5
Closed
3 tasks
radeksimko
radeksimko reviewed Mar 2, 2022
View reviewed changes
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand there's still some work left to do, as demonstrated by the failing tests but it's already in a pretty good shape, I think!

@jpogran
Copy link
Contributor Author

jpogran commented Mar 2, 2022

The failing tests are the static unit tests. I was focusing on ensuring the snapshots look as expected (only the non-specific parts should show hcl scopes, etc) and would update the unit tests.

Updating the unit test is tedious and error prone, so I was leaving them till last

dbanck
dbanck reviewed Mar 2, 2022
View reviewed changes
Copy link
Member

@dbanck dbanck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! I'm still reading up on scope injection docs, but this looks good so far!

jpogran
jpogran commented Mar 3, 2022
View reviewed changes
dbanck
dbanck approved these changes Mar 4, 2022
View reviewed changes
Copy link
Member

@dbanck dbanck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 👍

jpogran and others added 3 commits March 4, 2022 09:20
@jpogran jpogran marked this pull request as ready for review March 4, 2022 14:21
@jpogran jpogran merged commit d6ee9b7 into main Mar 4, 2022
@jpogran jpogran deleted the extract_hcl branch March 4, 2022 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@radeksimko radeksimko radeksimko left review comments

@dbanck dbanck dbanck approved these changes

Assignees

@jpogran jpogran

Labels
enhancement New feature or request
Projects
None yet
Milestone
0.1.0
Development

Successfully merging this pull request may close these issues.

Extract HCL2 grammar from terraform to new hcl grammar file
3 participants
@jpogran @dbanck @radeksimko