Terraform TextMate Test Infrastructure #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbanck
approved these changes
Jan 28, 2022
f9ad996 to
1de1847
Compare
|
Moving this to draft. Team has decided to work on the syntax directly on the version in the vscode-terraform repo, then move here once that is complete. |
1de1847 to
668c888
Compare
dbanck
approved these changes
Feb 25, 2022
.github/workflows/test.yml
Outdated
| on: | ||
| push: | ||
| branches: | ||
| - "master" |
This pulls in latest terraform.tmGrammar.json file from the [vscode-terraform project](https://github.com/hashicorp/vscode-terraform/blob/59174bd3e9a66c177a0f2de5751595d3f1cec838/syntaxes/terraform.tmGrammar.json).
This moves the Terraform grammar file to standard `syntaxes` directory instead of a product specific named directory. This is an unofficial convention among TextMate projects for the file that is distributed to clients.
This enables VS Code to provide intellisense and minimal validation of the tmGrammar files, whether they are json or yaml. It also adds a minimal prettier config to give enough room for the rule line lengths to not wrap excessively, which aids in reading large sections.
This adds testing infrastructure using `vscode-tmgrammar-test` to test the Terraform tmGrammar file. A minimal example file is used to demonstrate basic testing. Additional tests will be added as grammar is modified or changed.
This adds a test runner GitHub Action that runs against new pull requests.
This updates the README and adds documentation on how to edit and test the Terraform tmGrammar. It copies some wording from the vscode-terraform project.
668c888 to
fce7304
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
syntaxesdirectory instead of a product specific named directoryvscode-tmgrammar-testto test the Terraform tmGrammar file.Close #4