Copy patterns from HCL grammar to Terraform grammar #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This resolves an issue with nested include patterns. As soon as an include hits the HCL grammar file, it would never include anything from the Terraform grammar file. Because of this, highlighting of functions would break in deeper nested blocks or function calls. The commit introduces a lot of code duplication, but it all will go away with the introduction of templating for grammar files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes all cross-file include patterns from the Terraform grammar by duplicating the patterns from the HCL grammar.
In an editor of your choice, one can view the Terraform-specific changes best by comparing
terraform.tmGrammar.jsonandhcl.tmGrammar.json.Before
After
Closes #16