-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release Automation #15
Conversation
This adds a GitHub Action that packages up the syntax files for consumption in other products. The action is triggered by a git tag matching the version strategy we use and automatically generates a changelog inside the release based on all pull requests since last.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SHIPZ IT
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just minor notes in-line, nothing blocking.
Personally I think human-maintained changelog > generated changelog, but then to be fair generated changelog > no changelog 😄 so LGTM from that perspective.
RELEASE.md
Outdated
|
||
## Increment Version | ||
|
||
1. Ensure that CHANGELOG.MD has all changes since last release. Add if any are missing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that you decided to generate the changelog via gh
, is this still accurate?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This generates the text put into the GitHub Release. It does not update the CHANGELOG.md, yet. The generated text is not a 1:1 match to how we format our changelog, so I did not attempt to do that yet.
Co-authored-by: Radek Simko <radek.simko@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Co-authored-by: Daniel Banck <dbanck@users.noreply.github.com>
This adds a GitHub Action that packages up the syntax files for consumption in other products. The action is triggered by a git tag matching the version strategy we use and automatically generates a changelog inside the release based on all pull requests since last. A release document was added explaining the process.
A release would be downloaded using a URL like:
https://github.com/hashicorp/syntax/releases/download/v0.2.3/terraform.tmGrammar.json
An example release looks like this: