Add Sentinel Grammar #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2787054 to
a25d37e
Compare
Add https://github.com/hashicorp/vscode-sentinel/blob/81b8073d4ddb3b670c2a0742b682ef9343b06254/syntaxes/sentinel.tmlanguage.json to project. - Format file to conform to existing structure in hcl.tmGrammar.json. - Rename file to sentinel.tmGrammar.json
a25d37e to
4b4a656
Compare
radeksimko
approved these changes
Mar 9, 2022
| }, | ||
| { | ||
| "name": "keyword.control.sentinel", | ||
| "match": "\\b(if|case|for|any|all|filter|break|continue|return)\\b" |
There was a problem hiding this comment.
Suggested change
| "match": "\\b(if|case|for|any|all|filter|break|continue|return)\\b" | |
| "match": "\\b(if|case|for|any|all|filter|map|break|continue|return)\\b" |
https://docs.hashicorp.com/sentinel/language/spec#quantifier-expressions-any-all-filter-map
There was a problem hiding this comment.
Good catch! I'd rather address that in a separate PR as a dedicated fix instead of hiding it inside this port. I'll create the ticket and detail then merge this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add https://github.com/hashicorp/vscode-sentinel/blob/81b8073d4ddb3b670c2a0742b682ef9343b06254/syntaxes/sentinel.tmlanguage.json to project.