Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

walker: Pass through context to enable more granular validation #341

Merged
merged 5 commits into from
Nov 7, 2023
Merged

walker: Pass through context to enable more granular validation #341

merged 5 commits into from
Nov 7, 2023

Conversation

radeksimko
Copy link
Member

@radeksimko radeksimko commented Nov 3, 2023 •
edited
Loading

This is to support hashicorp/terraform-ls#1485 which is in turn a "workaround" for hashicorp/vscode-terraform#1616

@radeksimko radeksimko added the enhancement New feature or request label Nov 3, 2023
@radeksimko radeksimko force-pushed the f-validation-ctx-passthrough branch 3 times, most recently from 1593f3b to 2898e21 Compare November 3, 2023 15:43
@radeksimko radeksimko force-pushed the f-validation-ctx-passthrough branch from 2898e21 to 45dd3cb Compare November 6, 2023 10:52
@radeksimko radeksimko mentioned this pull request Nov 6, 2023
Merged
@radeksimko radeksimko force-pushed the f-validation-ctx-passthrough branch from 45dd3cb to 0d22b9d Compare November 6, 2023 11:11
@radeksimko radeksimko force-pushed the f-validation-ctx-passthrough branch from 769766b to 8254793 Compare November 6, 2023 15:59
@radeksimko radeksimko marked this pull request as ready for review November 6, 2023 16:03
@radeksimko radeksimko requested a review from a team as a code owner November 6, 2023 16:03
dbanck
dbanck approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@dbanck dbanck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks for addressing this

@radeksimko radeksimko merged commit c89603e into main Nov 7, 2023
@radeksimko radeksimko deleted the f-validation-ctx-passthrough branch November 7, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbanck dbanck dbanck approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@radeksimko @dbanck