Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

decoder: Add support for Reference as Constraint #185

Merged
merged 6 commits into from
Mar 24, 2023
Merged

decoder: Add support for Reference as Constraint #185

merged 6 commits into from
Mar 24, 2023

Conversation

radeksimko
Copy link
Member

@radeksimko radeksimko commented Jan 16, 2023 •
edited
Loading

Part of hashicorp/terraform-ls#496

There is quite a lot of logic related to reference collection, which I am not touching in this PR. That will be addressed more broadly as part of #239 I did however go through all the related legacy tests and made sure they pass (when using schema.Reference) in combination with this PR.

The updated tests are in c0a2da2

UX

2023-03-23 12 33 56

2023-03-23 12 35 57

@radeksimko radeksimko added the enhancement New feature or request label Jan 16, 2023
@radeksimko radeksimko force-pushed the f-expr-cons-reference branch from 6e478db to 1f7d84f Compare January 17, 2023 15:50
@radeksimko radeksimko self-assigned this Jan 23, 2023
@radeksimko radeksimko force-pushed the f-expr-cons-reference branch 3 times, most recently from 3f78a98 to 705f3b6 Compare January 30, 2023 09:29
@radeksimko radeksimko mentioned this pull request Jan 30, 2023
Merged
@radeksimko radeksimko force-pushed the f-expr-cons-reference branch from 705f3b6 to c3d83dc Compare January 31, 2023 10:11
@radeksimko radeksimko force-pushed the f-expr-cons-reference branch from c3d83dc to f58dcd5 Compare February 16, 2023 15:10
@radeksimko radeksimko removed their assignment Feb 16, 2023
@radeksimko radeksimko changed the title decoder/schema: Add support for Reference as Constraint decoder: Add support for Reference as Constraint Mar 7, 2023
@radeksimko radeksimko mentioned this pull request Mar 13, 2023
Closed
15 tasks
@radeksimko radeksimko self-assigned this Mar 16, 2023
@radeksimko radeksimko force-pushed the f-expr-cons-reference branch 8 times, most recently from 59128a1 to 23202d1 Compare March 22, 2023 11:26
@radeksimko radeksimko force-pushed the f-expr-cons-reference branch from 23202d1 to 7409f49 Compare March 22, 2023 15:46
@radeksimko radeksimko force-pushed the f-expr-cons-reference branch from 7409f49 to 871393e Compare March 22, 2023 20:42
This was referenced Mar 23, 2023
Open
Open
@radeksimko radeksimko force-pushed the f-expr-cons-reference branch from fc1f37e to 29857ca Compare March 23, 2023 10:48
@radeksimko radeksimko force-pushed the f-expr-cons-reference branch from 29857ca to 512e774 Compare March 23, 2023 11:20
@radeksimko radeksimko force-pushed the f-expr-cons-reference branch from 512e774 to 87468f3 Compare March 23, 2023 12:46
@radeksimko radeksimko marked this pull request as ready for review March 23, 2023 12:54
@radeksimko radeksimko requested a review from a team as a code owner March 23, 2023 12:54
@radeksimko radeksimko force-pushed the f-expr-cons-reference branch from 87468f3 to c301189 Compare March 23, 2023 18:01
jpogran
jpogran approved these changes Mar 24, 2023
View reviewed changes
Copy link
Contributor

@jpogran jpogran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@radeksimko radeksimko merged commit d469d16 into main Mar 24, 2023
@radeksimko radeksimko deleted the f-expr-cons-reference branch March 24, 2023 16:13
This was referenced Apr 25, 2023
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpogran jpogran jpogran approved these changes

Assignees

@radeksimko radeksimko

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@radeksimko @jpogran