Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable DocsLink for attributes #115

Merged
merged 4 commits into from
Apr 21, 2022
Merged

Enable DocsLink for attributes #115

merged 4 commits into from
Apr 21, 2022

Conversation

dbanck
Copy link
Member

@dbanck dbanck commented Apr 12, 2022

Required for hashicorp/vscode-terraform#673

This PR extends the collection of links inside a file from just blocks to attributes. With the change it's now possible to have an attribute (like source inside a module block) link to documentation.

@dbanck dbanck added the enhancement New feature or request label Apr 12, 2022
@dbanck dbanck self-assigned this Apr 12, 2022
@dbanck dbanck force-pushed the f-docslink-for-attrs branch from c1e953b to c223086 Compare April 13, 2022 14:47
@dbanck dbanck marked this pull request as ready for review April 13, 2022 14:56
@dbanck dbanck requested a review from a team April 13, 2022 14:56
@dbanck dbanck force-pushed the f-docslink-for-attrs branch from c223086 to fc4696c Compare April 19, 2022 13:55
@dbanck dbanck requested a review from radeksimko April 21, 2022 09:10
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Co-authored-by: Radek Simko <radek.simko@gmail.com>
@dbanck dbanck merged commit 480fdfd into main Apr 21, 2022
@dbanck dbanck deleted the f-docslink-for-attrs branch April 21, 2022 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants