Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit block type semantic token modifier inheritance to BodySchema #108

Closed
radeksimko opened this issue Mar 17, 2022 · 0 comments · Fixed by #109
Closed

Limit block type semantic token modifier inheritance to BodySchema #108

radeksimko opened this issue Mar 17, 2022 · 0 comments · Fixed by #109
Assignees
Labels
bug Something isn't working

Comments

@radeksimko
Copy link
Member

Background

Currently we let the block type modifiers be inherited indefinitely to any nested blocks within.

I am not sure whether that's what people want, but it's not something I originally intended in my initial PR.

This currently results in all nested blocks to have applied the same style as the root one:

Screenshot 2022-03-17 at 16 27 07

Proposal

Avoid inheritance for DependentBody body schemas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant