Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor ScImpl#contractGetInfo as an AnswerService in terms of HederaContracts #77

Closed
tinker-michaelj opened this issue May 12, 2020 · 0 comments · Fixed by #908
Closed

Refactor ScImpl#contractGetInfo as an AnswerService in terms of HederaContracts #77

tinker-michaelj opened this issue May 12, 2020 · 0 comments · Fixed by #908
Assignees
@tinker-michaelj

Comments

@tinker-michaelj
Copy link
Collaborator

Given an injected instance of HederaContracts, the query-answering logic for a valid ANSWER_ONLY version of ContractGetInfo should amount to:

  1. Extract the target contract from the query.
  2. Recover a HederaAccount from contracts.get(id), catching any exception.
  3. Provide a response from the HederaAccount/exception.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tinker-michaelj tinker-michaelj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reduce duplication in Smart Contract Service hashgraph/hedera-services
1 participant
@tinker-michaelj