Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve name, documentation & narrow condition for PLATFORM_TRANSACTION_NOT_CREATED response #314

Closed
noshmody opened this issue Jul 9, 2020 · 1 comment · Fixed by #448
Closed

Improve name, documentation & narrow condition for PLATFORM_TRANSACTION_NOT_CREATED response #314

noshmody opened this issue Jul 9, 2020 · 1 comment · Fixed by #448
Assignees
@SimiHunjan @donaldthibeau @tinker-michaelj @atul-hedera
Milestone
Hedera 0.7.0

Comments

@noshmody
Copy link

noshmody commented Jul 9, 2020

Improve name, documentation & narrow condition for PLATFORM_TRANSACTION_NOT_CREATED response code.

The current HAPI documentation for this response reads

PLATFORM_TRANSACTION_NOT_CREATED 69
transaction not created by platform due to either large backlog or message size exceeded transactionMaxBytes

This is overloaded since we also have TRANSACTION_OVERSIZE for transactions exceeding transactionMaxBytes.
@noshmody noshmody added the Bug An error that causes the feature to behave differently than what was expected based on design. label Jul 9, 2020
@noshmody noshmody added this to the Hedera 0.6.0 milestone Jul 9, 2020
@donaldthibeau
Copy link
Contributor

Should this be changed to:

Transaction not created by platform due to large backlog.

@noshmody noshmody added enhancement and removed Bug An error that causes the feature to behave differently than what was expected based on design. labels Jul 20, 2020
@noshmody noshmody modified the milestones: Hedera 0.6.0, Hedera 0.7.0 Jul 28, 2020
@noshmody noshmody added the doc label Aug 7, 2020
@tinker-michaelj tinker-michaelj mentioned this issue Aug 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SimiHunjan SimiHunjan

@donaldthibeau donaldthibeau

@tinker-michaelj tinker-michaelj

@atul-hedera atul-hedera

Labels
None yet
Projects
None yet
Milestone
Hedera 0.7.0
Development

Successfully merging a pull request may close this issue.

Update PLATFORM_TRANSACTION_NOT_CREATED comment hashgraph/hedera-services
5 participants
@noshmody @SimiHunjan @donaldthibeau @tinker-michaelj @atul-hedera